-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changing menu icons and Keeping sidebar unexpanded initially #1328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1328 +/- ##
==========================================
- Coverage 71.25% 71.24% -0.02%
==========================================
Files 102 102
Lines 7132 7150 +18
Branches 1623 1627 +4
==========================================
+ Hits 5082 5094 +12
- Misses 1932 1938 +6
Partials 118 118 ☔ View full report in Codecov by Sentry. |
himanshudube97
changed the title
Changing menu icons
Changing menu icons and Keeping sidebar unexpanded initially
Nov 25, 2024
fatchat
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed the menu icons according to figma. issue-1299
Menu items remain unexpanded when the
side drawer
is loaded. Only when user clicks the expand/collapse icon on the parent menu item then the child menu item expand/collapse. issue-1272The side Drawer shrinks and expands only when the Hamburger icon in the menubar is clicked. issue-1269