Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changing menu icons and Keeping sidebar unexpanded initially #1328

Merged
merged 11 commits into from
Nov 26, 2024

Conversation

himanshudube97
Copy link
Contributor

@himanshudube97 himanshudube97 commented Nov 25, 2024

  1. Changed the menu icons according to figma. issue-1299

  2. Menu items remain unexpanded when the side drawer is loaded. Only when user clicks the expand/collapse icon on the parent menu item then the child menu item expand/collapse. issue-1272

  3. The side Drawer shrinks and expands only when the Hamburger icon in the menubar is clicked. issue-1269

@himanshudube97 himanshudube97 linked an issue Nov 25, 2024 that may be closed by this pull request
Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 77.27273% with 5 lines in your changes missing coverage. Please review.

Project coverage is 71.24%. Comparing base (b3771bb) to head (0b36734).
Report is 12 commits behind head on main.

Files with missing lines Patch % Lines
src/components/SideDrawer/SideDrawer.tsx 73.68% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1328      +/-   ##
==========================================
- Coverage   71.25%   71.24%   -0.02%     
==========================================
  Files         102      102              
  Lines        7132     7150      +18     
  Branches     1623     1627       +4     
==========================================
+ Hits         5082     5094      +12     
- Misses       1932     1938       +6     
  Partials      118      118              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshudube97 himanshudube97 changed the title Changing menu icons Changing menu icons and Keeping sidebar unexpanded initially Nov 25, 2024
@fatchat fatchat merged commit 3b68444 into main Nov 26, 2024
4 of 5 checks passed
@fatchat fatchat deleted the changing-menu-icons branch November 26, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants