Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

second serach bar added #1270

Merged
merged 3 commits into from
Oct 17, 2024
Merged

second serach bar added #1270

merged 3 commits into from
Oct 17, 2024

Conversation

himanshudube97
Copy link
Contributor

@himanshudube97 himanshudube97 commented Oct 15, 2024

  1. Added a search bar to the list rendering Columns to keep in output table

  2. Changes in the code->

  • Keep a central state unpivotColFields which will be the single source of truth for bot the lists being renders.
  • derive the filtered lists filteredUnpivotColumns and filteredExcludeColumns based on the search inputs.
  • removed the colFieldData state. We already have unpivotColFields state. No need of duplications.

Copy link

codecov bot commented Oct 15, 2024

Codecov Report

Attention: Patch coverage is 75.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 71.20%. Comparing base (ca44660) to head (941d205).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
.../Components/OperationPanel/Forms/UnpivotOpForm.tsx 75.00% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1270      +/-   ##
==========================================
+ Coverage   71.05%   71.20%   +0.14%     
==========================================
  Files          97       97              
  Lines        6727     6703      -24     
  Branches     1478     1509      +31     
==========================================
- Hits         4780     4773       -7     
+ Misses       1914     1901      -13     
+ Partials       33       29       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@himanshudube97 himanshudube97 self-assigned this Oct 16, 2024
@fatchat fatchat linked an issue Oct 17, 2024 that may be closed by this pull request
@fatchat fatchat merged commit c66717b into main Oct 17, 2024
2 of 3 checks passed
@fatchat fatchat deleted the unpivot-need-second-search-bar branch October 17, 2024 02:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unpivot needs a second search bar
2 participants