Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aggregate returns an entire column containing the aggregated value in… #93

Merged
merged 2 commits into from
Mar 21, 2024

Conversation

fatchat
Copy link
Contributor

@fatchat fatchat commented Mar 21, 2024

… each row

@fatchat fatchat linked an issue Mar 21, 2024 that may be closed by this pull request
@fatchat fatchat requested a review from Ishankoradia March 21, 2024 08:32
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.65%. Comparing base (a664638) to head (2491c88).

Files Patch % Lines
dbt_automation/operations/aggregate.py 76.92% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #93      +/-   ##
==========================================
+ Coverage   72.63%   72.65%   +0.01%     
==========================================
  Files          28       28              
  Lines        1301     1309       +8     
==========================================
+ Hits          945      951       +6     
- Misses        356      358       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ishankoradia Ishankoradia merged commit 663b829 into main Mar 21, 2024
1 check passed
@Ishankoradia Ishankoradia deleted the 92-aggregation-needs-a-nested-query branch March 21, 2024 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

aggregation needs a nested query
3 participants