Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes in operation to match with the figma design & flow #77

Merged
merged 5 commits into from
Mar 7, 2024

Conversation

Ishankoradia
Copy link
Contributor

@Ishankoradia Ishankoradia commented Mar 7, 2024

  • Add default value option to coalesce operation. Constant value being used needs to be properly quoted.
  • Add support for replace operation. This is basically updating/replacing values in a column.
    • REPLACE operation in both warehouses only works for strings/text
    • Test for postgres
    • Test for bigquery
    • Test in merge operation chaining

@Ishankoradia Ishankoradia marked this pull request as draft March 7, 2024 10:11
@Ishankoradia Ishankoradia marked this pull request as ready for review March 7, 2024 12:11
@Ishankoradia Ishankoradia requested a review from fatchat March 7, 2024 12:43
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 77.04918% with 14 lines in your changes are missing coverage. Please review.

Project coverage is 80.70%. Comparing base (897a878) to head (a29b9c6).

Files Patch % Lines
dbt_automation/operations/replace.py 75.00% 10 Missing ⚠️
dbt_automation/operations/coalescecolumns.py 75.00% 3 Missing ⚠️
dbt_automation/utils/columnutils.py 83.33% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #77      +/-   ##
==========================================
- Coverage   80.84%   80.70%   -0.15%     
==========================================
  Files          22       23       +1     
  Lines         966     1026      +60     
==========================================
+ Hits          781      828      +47     
- Misses        185      198      +13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat merged commit 09fdf41 into main Mar 7, 2024
1 check passed
@fatchat fatchat deleted the updates-based-on-design branch March 7, 2024 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants