Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ui4t updates #64

Merged
merged 15 commits into from
Feb 29, 2024
Merged

ui4t updates #64

merged 15 commits into from
Feb 29, 2024

Conversation

Ishankoradia
Copy link
Contributor

@Ishankoradia Ishankoradia commented Feb 28, 2024

  • add support for data type for postgres
  • add support for data type for bigquery
  • Merge operations cte fixes; the operation doesn't output the correct cte.
  • update the merge operation to take input either as a source or a model. Currently it assumes the input to be a source.
  • _sql function of each operation needs to return the output columns also now. Update merge_operation accordingly.

@Ishankoradia Ishankoradia marked this pull request as draft February 28, 2024 18:30
@codecov-commenter
Copy link

codecov-commenter commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 92.10526% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 81.61%. Comparing base (5f54d62) to head (2905745).

Files Patch % Lines
dbt_automation/operations/flattenjson.py 0.00% 7 Missing ⚠️
dbt_automation/operations/mergeoperations.py 93.75% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main      #64      +/-   ##
==========================================
+ Coverage   81.55%   81.61%   +0.05%     
==========================================
  Files          22       22              
  Lines         949      952       +3     
==========================================
+ Hits          774      777       +3     
  Misses        175      175              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fatchat fatchat marked this pull request as ready for review February 29, 2024 16:57
@Ishankoradia Ishankoradia requested a review from fatchat February 29, 2024 16:57
@fatchat fatchat merged commit 313b6ee into main Feb 29, 2024
1 check passed
@fatchat fatchat deleted the ui4t-updates branch February 29, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment