-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fetching table data #38
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what happens when you initialize a BigQueryClient with no parameters? my guess is that all existing code will break
in the PostgresClient constructor, what happens if you pass a dictionary containing the keys DBHOST etc. all existing scripts which do this will break
Nothing will break now, we have updated all the other scripts as well with the correct field names for postgres client For bigquery , if we initialize with no conn_info ; it will now pick from service account json file specified in .env So the current scripts will work as is. If we initialize the bigquery client with connection info as None, it will throw a value error. Same for postgres client |
No description provided.