Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fetching table data #38

Merged
merged 9 commits into from
Oct 26, 2023
Merged

Fetching table data #38

merged 9 commits into from
Oct 26, 2023

Conversation

Abhishek-N
Copy link
Contributor

No description provided.

@Abhishek-N Abhishek-N requested a review from fatchat October 25, 2023 16:45
Copy link
Contributor

@fatchat fatchat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what happens when you initialize a BigQueryClient with no parameters? my guess is that all existing code will break

in the PostgresClient constructor, what happens if you pass a dictionary containing the keys DBHOST etc. all existing scripts which do this will break

Ishankoradia
Ishankoradia previously approved these changes Oct 26, 2023
@Ishankoradia
Copy link
Contributor

Ishankoradia commented Oct 26, 2023

existing code will break

Nothing will break now, we have updated all the other scripts as well with the correct field names for postgres client

For bigquery , if we initialize with no conn_info ; it will now pick from service account json file specified in .env

So the current scripts will work as is.

If we initialize the bigquery client with connection info as None, it will throw a value error. Same for postgres client
If we initialize the bigquery client with the wrong connection info, it will throw an exception google.auth.exceptions...
While the postgres client with throw psycopg2.OperationalError
So we can't move forward unless a valid client is initialized

@Ishankoradia Ishankoradia requested a review from fatchat October 26, 2023 10:37
@fatchat fatchat merged commit 949a207 into main Oct 26, 2023
@fatchat fatchat deleted the fetching-table-data branch October 26, 2023 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants