Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

download preview data bug #938

Merged
merged 3 commits into from
Jan 27, 2025
Merged

download preview data bug #938

merged 3 commits into from
Jan 27, 2025

Conversation

Ishankoradia
Copy link
Contributor

  • StringIO() and DictWriter are being initialized multiple times , which is causing the data descrepancy while writing

@Ishankoradia Ishankoradia requested a review from fatchat January 24, 2025 11:17
@Ishankoradia
Copy link
Contributor Author

Fixes #932

@fatchat
Copy link
Contributor

fatchat commented Jan 24, 2025

tested from a juypter notebook and didn't see duplicates

Copy link

codecov bot commented Jan 27, 2025

Codecov Report

Attention: Patch coverage is 72.00000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.85%. Comparing base (e791bd1) to head (d63ab59).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
ddpui/tests/api_tests/test_warehouse_api.py 12.50% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #938      +/-   ##
==========================================
- Coverage   82.90%   82.85%   -0.05%     
==========================================
  Files         150      150              
  Lines       15524    15525       +1     
==========================================
- Hits        12870    12864       -6     
- Misses       2654     2661       +7     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Ishankoradia Ishankoradia merged commit 755ddc9 into main Jan 27, 2025
2 of 4 checks passed
@Ishankoradia Ishankoradia deleted the bug/download-preview-data branch January 27, 2025 04:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants