Serialize work type ID #165
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Serialize the ID of work types to be able to use the
`/api/library/work-types/{id}` route, otherwise the ID has to be guessed.
Found while trying to implement feeding in Japan7/karaberus#38
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #165 +/- ##
========================================
Coverage 98.69% 98.69%
========================================
Files 73 73
Lines 1836 1836
========================================
Hits 1812 1812
Misses 24 24 ☔ View full report in Codecov by Sentry. |
odrling
added a commit
to Japan7/karaberus
that referenced
this pull request
Jul 25, 2024
Feed tags/medias/artists/karas to dakara on upload and on startup. Define tag colors (hue) so we can set colors in karaberus and have it change in dakara at the same time. Could be obviously improved by checking locally for changes of karaokes, medias and artists instead of just PUTing everything on sync. Probably not worth it implement that for tags. We can't yet update work types decently because dakara doesn't return their IDs. (DakaraProject/dakara-server#165) This assumes that video files will all be called `{id}.mkv`, so the downloader will have to follow this naming scheme to work with dakara. The files are not all matroska files, but it should not be a problem in practice. #40
odrling
added a commit
to Japan7/karaberus
that referenced
this pull request
Jul 25, 2024
Feed tags/medias/artists/karas to dakara on upload and on startup. Define tag colors (hue) so we can set colors in karaberus and have it change in dakara at the same time. Could be obviously improved by checking locally for changes of karaokes, medias and artists instead of just PUTing everything on sync. Probably not worth it implement that for tags. We can't yet update work types decently because dakara doesn't return their IDs. (DakaraProject/dakara-server#165) This assumes that video files will all be called `{id}.mkv`, so the downloader will have to follow this naming scheme to work with dakara. The files are not all matroska files, but it should not be a problem in practice. #40
|
Please update test helper here. |
|
I can't seem to get the tests to pass, |
|
Ah, the helper is also used to assert work type obtained by other serializers (namely, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Serialize the ID of work types to be able to use the
/api/library/work-types/{id}route, otherwise the ID has to be guessed.Found while trying to implement feeding in Japan7/karaberus#38