Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setup ruff as a flake8 replacement #31

Merged
merged 5 commits into from
Mar 16, 2024
Merged

setup ruff as a flake8 replacement #31

merged 5 commits into from
Mar 16, 2024

Conversation

odrling
Copy link
Contributor

@odrling odrling commented Mar 16, 2024

ruff runs pretty fast, which is nice when used as a pre-commit hook.

It also implements more checks that can be selected as needed, in this
PR I add the bugbear (B) checks which were not present in the
previous configuration and fix the issues that it reports.

odrling added 3 commits March 16, 2024 00:32
ruff runs pretty fast, which is nice when used as a pre-commit hook.

It also implements more checks that can be selected as needed, in this
commit I add the bugbear (B) checks which were not present in the
previous configuration.
reported by the bugbear checks
Copy link

codecov bot commented Mar 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (3aea2aa) to head (99259d5).

Additional details and impacted files
@@            Coverage Diff            @@
##           develop       #31   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           19        19           
  Lines          824       824           
=========================================
  Hits           824       824           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Neraste
Copy link
Member

Neraste commented Mar 16, 2024

Nice job. Please fix ruff warnings during tests and set ruff version by interval in pyproject.toml.

@Neraste Neraste merged commit f503557 into develop Mar 16, 2024
21 checks passed
@Neraste Neraste deleted the ruff branch March 16, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants