Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hotfix boolean matrix and extractor #47

Merged
merged 4 commits into from
Dec 26, 2023
Merged

Hotfix boolean matrix and extractor #47

merged 4 commits into from
Dec 26, 2023

Conversation

chinyi0523
Copy link
Contributor

@chinyi0523 chinyi0523 commented Dec 26, 2023 •
edited by JoshuaLau0220
Loading

Check List

  1. Does your submission pass tests by running make test?
  2. If you have specified a [no ci] tag, does your submission also pass tests by running make test-docker?
  3. Have you linted your code locally with make lint before submission?

Fixed

  • Only remove operations with identical sources and targets in filter_duplicate_row_operations
  • Fix starting point of backward elimination in gaussian_elimination_skip
  • Do not remove phase nodes in Extractor::initialize

@chinyi0523 chinyi0523 added the bug Something isn't working label Dec 26, 2023
@chinyi0523 chinyi0523 removed the request for review from JoshuaLau0220 December 26, 2023 09:18
@chinyi0523 chinyi0523 linked an issue Dec 26, 2023 that may be closed by this pull request
ZX2QC by Gaussian not equivalence #46
Closed
@chinyi0523 chinyi0523 merged commit e2b3b7b into develop Dec 26, 2023
4 checks passed
@chinyi0523 chinyi0523 deleted the hotfix-boolean-matrix branch February 13, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ZX2QC by Gaussian not equivalence
1 participant
@chinyi0523