Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dynamic Extraction #137

Merged
merged 22 commits into from
Aug 20, 2024
Merged

Dynamic Extraction #137

merged 22 commits into from
Aug 20, 2024

Conversation

chinyi0523
Copy link
Contributor

Check List

  1. Does your submission pass tests by running make test?
  2. If you have specified a [no ci] tag, does your submission also pass tests by running make test-docker?
  3. Have you linted your code locally with make lint before submission?

Added

  • Dynamic extraction features

Changed

Fixed

Removed

@JoshuaLau0220
Copy link
Collaborator

The Ubuntu tests failed because apt update was missing before apt install in the docker scripts. I'm not sure why it was not a problem before, but I've fixed it now.

What's remaining seems to be the test tests/conversion/zx2qc/extractStep.dof not passing. This was because the compiler implicitly cast the nullptr to false in the constructor of Extractor, so the extractor is not extracting to the focused QCir. I've swapped the param for QCir and the random flag to avoid this bad casting from happening.

@JoshuaLau0220 JoshuaLau0220 merged commit e56015b into develop Aug 20, 2024
4 checks passed
@JoshuaLau0220 JoshuaLau0220 deleted the gflow-extract branch October 17, 2024 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants