Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dcwc 640 search grid #55

Merged
merged 3 commits into from
Oct 26, 2021
Merged

Dcwc 640 search grid #55

merged 3 commits into from
Oct 26, 2021

Conversation

nibivi77
Copy link
Collaborator

DCWC-640

Description

Revamped the MostRequestedList to CardList so that it is more generic. We can easily edit it later and reuse this component.

Added a placeholder list in the searchResult page.

What to test for/How to test

Additional Notes

  • No filtering functionality. This is purely placeholders.

@nibivi77 nibivi77 requested a review from a team October 22, 2021 18:04
@lgtm-com
Copy link

lgtm-com bot commented Oct 22, 2021

This pull request introduces 1 alert when merging d191649 into 44bb289 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

Copy link
Contributor

@DaceyTom2 DaceyTom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks amazing. The gray surprisingly doesn't clash either.
Ty for taking the time to rename and reuse the cards

@nibivi77 nibivi77 merged commit eaa69ba into dev Oct 26, 2021
@P0NDER0SA P0NDER0SA deleted the DCWC-640-search-grid branch November 24, 2021 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants