Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added layout-container. #51

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Added layout-container. #51

merged 2 commits into from
Oct 13, 2021

Conversation

nibivi77
Copy link
Collaborator

DCWC-464

Description

Added layout-container as a CSS global class.

What to test for/How to test

Test all screen widths.

Additional Notes

  • The search card component is tricky and a little unclear how it should respond to screen size change so I left it as is.

@nibivi77 nibivi77 requested a review from a team October 13, 2021 14:32
Copy link
Contributor

@DaceyTom2 DaceyTom2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks really good.
Small thing, the search should align with My Service Canada

image

@nibivi77
Copy link
Collaborator Author

This looks really good. Small thing, the search should align with My Service Canada

image

Yep I left a comment about that. Do you want me to see what I can do? the designs are a bit weird for that. it would squish the search section really tight

@DaceyTom2
Copy link
Contributor

Missed your comment! Will approve

@nibivi77
Copy link
Collaborator Author

Just trying to make the search section fit better.

@nibivi77 nibivi77 merged commit 053bb0e into dev Oct 13, 2021
@P0NDER0SA P0NDER0SA deleted the DCWC-464-home-container branch November 24, 2021 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants