Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure /reload/ (hard reload) path is included in SSR paths. #3935

Merged
merged 1 commit into from
Feb 3, 2025
Merged

Ensure /reload/ (hard reload) path is included in SSR paths. #3935

merged 1 commit into from
Feb 3, 2025

Conversation

tdonohue
Copy link
Member

References

Description

This small PR just ensures that /reload/ paths always trigger SSR. This fixes the odd behavior seen in #3934.

Instructions for Reviewers

@tdonohue tdonohue added bug high priority performance / caching Related to performance, caching or embedded objects 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 31, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 31, 2025
@tdonohue tdonohue force-pushed the add_reload_to_ssr_paths branch from c588bcf to 83d24f8 Compare January 31, 2025 20:34
kshepherd
kshepherd approved these changes Feb 3, 2025
View reviewed changes
Copy link
Member

@kshepherd kshepherd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 by inspection thanks @tdonohue

@kshepherd kshepherd merged commit 073cd07 into DSpace:main Feb 3, 2025
15 checks passed
@dspace-bot dspace-bot mentioned this pull request Feb 3, 2025
Merged
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-7_x:

@dspace-bot dspace-bot mentioned this pull request Feb 3, 2025
Merged
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue deleted the add_reload_to_ssr_paths branch February 3, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kshepherd kshepherd kshepherd approved these changes

Assignees

@tdonohue tdonohue

Labels
1 APPROVAL pull request only requires a single approval to merge bug high priority performance / caching Related to performance, caching or embedded objects port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release
Projects
DSpace 9.0 Release
Status: ✅ Done
Milestone
9.0
Development

Successfully merging this pull request may close these issues.

When "/reload/" paths are not enabled for SSR, sometimes i18n language pack fails to load
3 participants
@tdonohue @dspace-bot @kshepherd