Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attempt to stabilize a few randomly failing e2e tests #3842

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

tdonohue
Copy link
Member

Description

This small PR is an attempt to stabilize a few randomly failing e2e tests.

  1. Sometimes tests which use the Admin sidebar will fail randomly if the sidebar link is not yet visible when it's clicked on. The first commit in this PR attempts to fix that issue.
  2. item-edit.cy.ts will sometimes randomly fail if the tabs have not fully loaded. The second commit attempts to fix this issue by waiting on the current tab to be visible before clicking on it, and then ensuring it's visible again after reload of the page.

Instructions for Reviewers

  • This PR only touches e2e tests. If those pass, it can be merged.

@tdonohue tdonohue added bug 1 APPROVAL pull request only requires a single approval to merge testing framework Related specifically to Unit or Integration (e2e) Tests port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 15, 2025
@tdonohue tdonohue added this to the 9.0 milestone Jan 15, 2025
@tdonohue
Copy link
Member Author

Merging immediately & porting. Hoping this stabilizes things a bit more (several of these are randomly failing at a greater frequency recently)

@tdonohue tdonohue merged commit c20bf58 into DSpace:main Jan 15, 2025
15 checks passed
@dspace-bot
Copy link
Contributor

Backport failed for dspace-7_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3842-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3842-to-dspace-7_x
git switch --create backport-3842-to-dspace-7_x
git cherry-pick -x 5623cc9221ef55f073d54b30efcf42684e9a4455 7feb9fc617f88f57927eb7d6de7b4ed8fa0ce870

@dspace-bot
Copy link
Contributor

Backport failed for dspace-8_x, because it was unable to cherry-pick the commit(s).

Please cherry-pick the changes locally and resolve any conflicts.

git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3842-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3842-to-dspace-8_x
git switch --create backport-3842-to-dspace-8_x
git cherry-pick -x 5623cc9221ef55f073d54b30efcf42684e9a4455 7feb9fc617f88f57927eb7d6de7b4ed8fa0ce870

@tdonohue tdonohue deleted the test_stabilization branch January 16, 2025 14:55
@tdonohue tdonohue removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release labels Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge bug testing framework Related specifically to Unit or Integration (e2e) Tests
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants