-
Notifications
You must be signed in to change notification settings - Fork 439
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Live Region #3337
Live Region #3337
Conversation
# Conflicts: # config/config.example.yml # src/app/shared/shared.module.ts # src/config/app-config.interface.ts # src/config/default-app-config.ts # src/environments/environment.test.ts
I think the PR is good and very helpful in closing some other accessibility tasks. I'm eager for this to be merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@AAwouters : This looks great to me, but I'd ask that you add some basic TypeDocs to the new LiveRegion service & component. These TypeDocs/comments are useful for other developers to understand the purpose of these new classes.
Once that is added, I'll merge this immediately.
# Conflicts: # src/app/shared/live-region/live-region.component.ts # src/app/shared/live-region/live-region.service.spec.ts
da7a8f5
to
0f5a50a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Thanks @AAwouters ! This looks good now. Because this is related to accessibility & other accessibility fixes will likely depend on it, I'm flagging this for backport to 8.x and 7.6.x. This should trigger an automated backport...but if one of those fail, we may need to manually backport.
(Sidenote: the Codecov coverage failure in this PR appears to be a false positive.)
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-7_x
git worktree add -d .worktree/backport-3337-to-dspace-7_x origin/dspace-7_x
cd .worktree/backport-3337-to-dspace-7_x
git switch --create backport-3337-to-dspace-7_x
git cherry-pick -x 83a44ba924fb20065f0bb62fc2a09a7aaec391bc e987c35450f2a03e73fe5a9951ec412fb9675e33 35d29c84258e1656ed17c53e6e7054c69b7878d1 c1fa52ee64e7c50f38c0e671aa13757bc7a4c024 751d689ff65b15fa4f8b2f898d43ecaa682e8085 |
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin dspace-8_x
git worktree add -d .worktree/backport-3337-to-dspace-8_x origin/dspace-8_x
cd .worktree/backport-3337-to-dspace-8_x
git switch --create backport-3337-to-dspace-8_x
git cherry-pick -x 83a44ba924fb20065f0bb62fc2a09a7aaec391bc e987c35450f2a03e73fe5a9951ec412fb9675e33 35d29c84258e1656ed17c53e6e7054c69b7878d1 c1fa52ee64e7c50f38c0e671aa13757bc7a4c024 751d689ff65b15fa4f8b2f898d43ecaa682e8085 |
@AAwouters : Could you create a backport of this PR for the |
Description
This PR adds the LiveRegion Service & Component. The live region component is invisible by default, but any messages pushed to the service are added to the component so screen readers can announce the message.
By itself this PR does very little but is intended as building block for issues such as #1271 and #3154.
Instructions for Reviewers
At the moment of this PR, the functionality of the live region is not used by any component so to test it a reviewer will have to do this manually.
config.dev.yml
(or equivalent) addliveRegion: isVisible: true
to make the live region visible at the bottom of the page.One option to quickly test the region is to add the following code to the body of the
live-region.component.ts
:This will add the message "Click!" to the live region every time the reviewer clicks the mouse button.
CheckList
yarn lint
yarn check-circ-deps
)User interface changes must align with Accessibility guidelinesnot applicablePRs must use i18n (internationalization) keys instead of hardcoded English text, to allow for translations.not applicableIf a PR includes new libraries/dependencies (innot applicablepackage.json
), then their software licenses must align with the DSpace BSD License based on the Licensing of Contributions documentation.