Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Arabic Translation #3144

Merged
merged 1 commit into from
Oct 14, 2024
Merged

Update Arabic Translation #3144

merged 1 commit into from
Oct 14, 2024

Conversation

mohamedali654321
Copy link
Contributor

@mohamedali654321 mohamedali654321 commented Jun 26, 2024

Update Arabic Translation by KnowledgeWare Technologies Est.

Update ar.json5 translation

References

Add references/links to any related issues or PRs. These may include:

  • Fixes #issue-number (if this fixes an issue ticket)
  • Requires DSpace/DSpace#pr-number (if a REST API PR is required to test this)

Description

Short summary of changes (1-2 sentences).

Instructions for Reviewers

Please add a more detailed description of the changes made by your PR. At a minimum, providing a bulleted list of changes in your PR is helpful to reviewers.

List of changes in this PR:

  • First, ...
  • Second, ...

Include guidance for how to test or review your PR. This may include: steps to reproduce a bug, screenshots or description of a new feature, or reasons behind specific changes.

Checklist

This checklist provides a reminder of what we are going to look for when reviewing your PR. You need not complete this checklist prior to creating your PR (draft PRs are always welcome). If you are unsure about an item in the checklist, don't hesitate to ask. We're here to help!

  • My PR is small in size (e.g. less than 1,000 lines of code, not including comments & specs/tests), or I have provided reasons as to why that's not possible.
  • My PR passes ESLint validation using yarn lint
  • My PR doesn't introduce circular dependencies (verified via yarn check-circ-deps)
  • My PR includes TypeDoc comments for all new (or modified) public methods and classes. It also includes TypeDoc for large or complex private methods.
  • My PR passes all specs/tests and includes new/updated specs or tests based on the Code Testing Guide.
  • If my PR includes new libraries/dependencies (in package.json), I've made sure their licenses align with the DSpace BSD License based on the Licensing of Contributions documentation.
  • If my PR includes new features or configurations, I've provided basic technical documentation in the PR itself.
  • If my PR fixes an issue ticket, I've linked them together.

Update Arabic Translation

Update  ar.json5 translation
@tdonohue tdonohue added i18n / l10n Internationalisation and localisation, related to message catalogs 1 APPROVAL pull request only requires a single approval to merge port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jun 26, 2024
@Massoud-Alshareef
Copy link

This PR provides the Arabic Translation of DSpace 8.0 strings as found in DSpace 8 repository at the time of its official release announcement. It has been loaded in our DSpace 8 demo instance (https://dspace8.kwaretech.com/) currently under testing.

We will wait until DSpace 8.1 strings freeze to add the translation of those additional strings that will come with 8.1.

Thanks, Massoud.

@tdonohue tdonohue added port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release and removed port to dspace-7_x This PR needs to be ported to `dspace-7_x` branch for next bug-fix release labels Jul 25, 2024
Copy link
Member

@tdonohue tdonohue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @mohamedali654321 for this translation update. This looks good to me. (Apologies for the delay in getting to this one)

@tdonohue tdonohue added this to the 9.0 milestone Oct 14, 2024
@tdonohue tdonohue merged commit fa601fc into DSpace:main Oct 14, 2024
13 checks passed
@dspace-bot
Copy link
Contributor

Successfully created backport PR for dspace-8_x:

@tdonohue tdonohue removed the port to dspace-8_x This PR needs to be ported to `dspace-8_x` branch for next bug-fix release label Oct 14, 2024
@Massoud-Alshareef
Copy link

Massoud-Alshareef commented Oct 15, 2024 via email

@tdonohue
Copy link
Member

@mohamedali654321 and @Massoud-Alshareef : At this time, unfortunately, we don't have anyone who is able to notify all translators when a new translation is ready to create. So, you must be proactive if you want to keep the Arabic translation up to date at all times.

However, I can state that minor release (e.g. 8.1) tend to have few or no new i18n keys, because they are bug-fix only releases. So, it's likely that 8.1 will be very little effort (when that release is ready).

For 9.0, the best approach would likely be to work on an updated translation as soon as the 9.0 Community Testathon is announced. Tentatively that would be in the Feb/Mar timeframe next year (2025). The 9.0 release is tentatively due in April 2025 (date to be determined), so I'd recommend considering doing an updated translation in Feb or Mar.

The final 9.0 release schedule will be posted to our Developer Meeting agendas as soon as it is ready (it is still being worked out). So, you can also follow along with that release schedule in Developer Meeting agendas/notes here: https://wiki.lyrasis.org/display/DSPACE/Developer+Meetings

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1 APPROVAL pull request only requires a single approval to merge i18n / l10n Internationalisation and localisation, related to message catalogs
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

4 participants