Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

修正副产物的计算逻辑 #13

Merged
merged 7 commits into from
Jan 9, 2024
Merged

Conversation

makuwa8992
Copy link
Collaborator

当初更改item_price的时候把副产物的收获一起算到item_price里了,然后我记得下面一段计算副产物收获的内容删了或注释了,后来不知道可能是哪一次合并又把这段加了回来,导致副产物产出算了两次,现在这边再次删掉

@makuwa8992
Copy link
Collaborator Author

顺道更正以后把0.4.5的tag换成这个吧

package.json Outdated
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

为何需要安装一个新的包?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

啊,我这里是因为原先我本地的环境跑不了改了webp以后的那个版本,然后按它的报错在网上找教程然后一个个手动install才解决的,都没注意吧这里也改了,把这一步删了吧

@JimmyZJX
Copy link
Collaborator

JimmyZJX commented Jan 9, 2024

我觉得还是不要改以前release过的版本号,还是+1再release一个新版本吧

@makuwa8992
Copy link
Collaborator Author

我觉得还是不要改以前release过的版本号,还是+1再release一个新版本吧

主要现在的0.4.5计算逻辑上有问题,这不是布局之类的小问题,最好还是别有这个基础功能上出问题的版本,不过我也拿不准主要,这种情况还是按你想的来吧

@JimmyZJX
Copy link
Collaborator

JimmyZJX commented Jan 9, 2024

我觉得正是因为有bug所以应该新开一个版本,这样就能区分出来用户给的bug report到底是什么原因引起的

@makuwa8992
Copy link
Collaborator Author

我觉得正是因为有bug所以应该新开一个版本,这样就能区分出来用户给的bug report到底是什么原因引起的

行,那就这么办吧

@JimmyZJX JimmyZJX merged commit c72b220 into DSPCalculator:main Jan 9, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants