[FEAT/seminar1] 심화과제 / 도전과제 #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jokwanhee
reviewed
Nov 3, 2023
| return super.dispatchTouchEvent(ev) | ||
| } | ||
|
|
||
| private fun hideKeyboard() { |
There was a problem hiding this comment.
저도 이 부분 코드리뷰로 확장함수를 처리해서 사용하니 다른 곳에서도 확장성있게 사용할 수 있어서! 좋았습니다!
| import org.sopt.dosopttemplate.data.entity.UserData | ||
|
|
||
|
|
||
| object SharedPreference { |
There was a problem hiding this comment.
오.. 저도 SharedPreference 사용할 때 object 를 사용하면 범용성있게 사용할 수 있겠네요.. 저도 리팩토링할 때 참고하도록 하겠습니다
| fun isValidUserData() = prefs.getString(USER_ID, "")?.isNotBlank() ?: false | ||
|
|
||
| fun setUserData(user: UserData) { | ||
| with(prefs.edit()) { |
There was a problem hiding this comment.
요 부분 SharedPreference ktx 사용하면 아래 코드처럼 사용할 수 있더라구요 (의진이가 알려줬습니다!)
prefs.edit(commit = true) {
putString(USER_ID, user.id)
putString(USER_PW, user.pw)
putString(USER_NICKNAME, user.nickName)
putString(USER_MBTI, user.mbti)
}| @@ -16,58 +17,69 @@ import org.sopt.dosopttemplate.util.getParcelable | |||
|
|
|||
| class LogInActivity : BaseActivity<ActivityLoginBinding>(R.layout.activity_login) { | |||
| private lateinit var resultLauncher: ActivityResultLauncher<Intent> | |||
| private lateinit var userData: UserData | |||
| private var userData: UserData = UserData("", "", "", "") | |||
There was a problem hiding this comment.
UserData 객체를 할당할 때, 생성자로 값을 넘겨주는 것보단 코틀린에서는 default value 를 제공해주니깐 아래와 같이 사용해도 좋을 것 같다는 개인적인 생각을 했습니다!
data class UserData (
val id: String = ""
)private var userData: UserData = UserData()There was a problem hiding this comment.
이런 식으로 사용하는 게 더 좋을 것 같네요!!
kez-lab
approved these changes
Nov 3, 2023
Comment on lines
38
to
50
| private fun initFinishApp() { | ||
| onBackPressedDispatcher.addCallback(this, object : OnBackPressedCallback(true) { | ||
| override fun handleOnBackPressed() { | ||
| if (System.currentTimeMillis() - backPressedTime >= 2000L) { | ||
| backPressedTime = System.currentTimeMillis() | ||
| SnackBar.makeSnackBar(binding.root, BACK_MESSAGE) | ||
| } else { | ||
| finishAffinity() | ||
| } | ||
| } | ||
| } | ||
| ) | ||
| } |
There was a problem hiding this comment.
함수명이 조금 모호한 것 같아요! 혹시 더 좋은 네이밍 없을까요?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
✍️ Work Description
심화과제
도전과제
📸 ScreenShot
심화과제
1_2.mp4
도전과제
1_3.mp4
🍀 Issues
#5
✔️ PR point
심화과제
도전과제