Added programmatic support to focus or blur elements #1119
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All elements that are interactable with now support programatic focus or blur. This is a followup on DNNCommunity#1116 which was working but not great: 1: Elements already have a built-in focus and blur methods as long as they have a tabIndex. 2: It was giving a stencil compiler warning that developers should not define methods with the same names as the DOM already have. This solution is simpler and covers all the interactable elements. Closes DNNCommunity#1055
|
Oh, just to explain a little, the Host (our component) passes the focus or blur call to the first focusable element it contains. Our component has a tabIndex if it is not already focused. When it is already focuses, it does not have a tabIndex because that would cause the whole thing to be displayed with the focused style when doing |
david-poindexter
requested changes
Jul 24, 2024
packages/stencil-library/src/components/dnn-monaco-editor/dnn-monaco-editor.tsx
Outdated
Show resolved
Hide resolved
…monaco-editor.tsx Co-authored-by: David Poindexter <dpoindexter@nvisionative.com>
david-poindexter
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All elements that are interactable with now support programmatic focus or blur.
This is a follow up on #1116 which was working but not great: 1: Elements already have a built-in focus and blur methods as long as they have a tabIndex. 2: It was giving a stencil compiler warning that developers should not define methods with the same names as the DOM already have.
This solution is simpler and covers all the interactable elements.
Closes #1055