Fix undefined _mm_{malloc,free} with LLVM/MinGW #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MinGW defines _mm_{malloc,free} only for x86(-64), but not for Arm.
Co-authored-by: bruvzg <7645683+bruvzg@users.noreply.github.com>
|
If an alignment of 1 is passed to _mm_malloc(), this implementation will allocate with malloc() and then _mm_free() will free with _aligned_free(). The latter function is only designed to free memory allocated with an _aligned function. I think if you're going to use _aligned_malloc() at all, it needs to be done unconditionally, not just for certain alignments. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.