Exclude _mm_malloc/free definitions on Windows #541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jserv
reviewed
Oct 18, 2022
|
By the way, are you able to build SSE2NEON with MSVC? |
Definitions for these functions are provided by malloc.h from both MinGW-w64 and MSVC. When they are defined again by sse2neon, it causes multiple definition errors. Furthermore, the implementation in sse2neon relies on posix_memalign which is unavailable on Windows.
864f97f to
9941d31
Compare
I've started looking at it. If I complete the work, I'll send a separate PR. |
|
Thank @invertego for contributing! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Definitions for these functions are provided by malloc.h from both MinGW-w64 and MSVC. When they are defined again by sse2neon, it causes multiple definition errors. Furthermore, the implementation in sse2neon relies on posix_memalign which is unavailable on Windows.