Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced ENABLE_LESS_TESTS by TEST_LEVEL #1413

Merged
merged 6 commits into from
Feb 20, 2025

Conversation

lenaploetzke
Copy link
Collaborator

Describe your changes here:
Replaced ENABLE_LESS_TESTS by TEST_LEVEL as we want to have an additional test level running even less tests than with the LESS_TEST option
This is related to #1371

All these boxes must be checked by the reviewers before merging the pull request:

As a reviewer please read through all the code lines and make sure that the code is fully understood, bug free, well-documented and well-structured.

General

  • The reviewer executed the new code features at least once and checked the results manually

  • The code follows the t8code coding guidelines

  • New source/header files are properly added to the Makefiles

  • The code is well documented

  • All function declarations, structs/classes and their members have a proper doxygen documentation

  • All new algorithms and data structures are sufficiently optimal in terms of memory and runtime (If this should be merged, but there is still potential for optimization, create a new issue)

Tests

  • The code is covered in an existing or new test case using Google Test

Github action

  • The code compiles without warning in debugging and release mode, with and without MPI (this should be executed automatically in a github action)

  • All tests pass (in various configurations, this should be executed automatically in a github action)

    If the Pull request introduces code that is not covered by the github action (for example coupling with a new library):

    • Should this use case be added to the github action?
    • If not, does the specific use case compile and all tests pass (check manually)

Scripts and Wiki

  • If a new directory with source-files is added, it must be covered by the script/find_all_source_files.scp to check the indentation of these files.
  • If this PR introduces a new feature, it must be covered in an example/tutorial and a Wiki article.

License

  • The author added a BSD statement to doc/ (or already has one)

Tag Label

  • The author added the patch/minor/major label in accordance to semantic versioning.

@lenaploetzke lenaploetzke linked an issue Feb 18, 2025 that may be closed by this pull request
@lenaploetzke lenaploetzke added the draft Enhance the visibility that this is a draft. label Feb 18, 2025
@ole-alb ole-alb self-assigned this Feb 18, 2025
@lenaploetzke lenaploetzke marked this pull request as ready for review February 18, 2025 14:26
@lenaploetzke lenaploetzke requested a review from ole-alb February 18, 2025 14:27
@lenaploetzke lenaploetzke added shouldn't take long Can be resolved in under 30 mins priority: medium Should be solved within half a year and removed draft Enhance the visibility that this is a draft. labels Feb 18, 2025
@ole-alb ole-alb assigned lenaploetzke and unassigned ole-alb Feb 20, 2025
@ole-alb ole-alb added this pull request to the merge queue Feb 20, 2025
Merged via the queue into main with commit 5e8ede8 Feb 20, 2025
20 checks passed
@ole-alb ole-alb deleted the 1371-add-t8_enable_minimal_tests branch February 20, 2025 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: medium Should be solved within half a year shouldn't take long Can be resolved in under 30 mins
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants