Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[prioritize] refuse to automatically prioritize dig jobs #865

Merged
merged 1 commit into from
Oct 15, 2023

Conversation

myk002
Copy link
Member

@myk002 myk002 commented Oct 15, 2023

since so many jobs can bork the DF job scheduler. print a warning instead.

@myk002 myk002 merged commit 7450359 into DFHack:master Oct 15, 2023
9 checks passed
@myk002 myk002 deleted the myk_no_prioritize_dig branch October 15, 2023 21:49
@ab9rf
Copy link
Member

ab9rf commented Oct 15, 2023

i would suggest that a better idea might be to refuse to prioritize any combination of jobs where the number of jobs affected exceeds the number of units in the fort available to do labors

@myk002
Copy link
Member Author

myk002 commented Oct 16, 2023

Marking a lot of jobs by itself is not usually an issue. If we mark 500 BringItemToDepot jobs as do_now, that's perfectly fine. The problem with dig jobs is that they continuously trickle in, which is far more disruptive to the fortress than getting all hands on deck for a single-shot burst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants