This repository has been archived by the owner on Mar 16, 2020. It is now read-only.
Open a subject accordion section when it contains a ticked checkbox #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They contained a space.
This is to maintain the state of the page when users browse back from the results.
fofr
approved these changes
Sep 27, 2018
|
👌 |
tvararu
added a commit
that referenced
this pull request
Sep 27, 2018
This is a better version of this previous PR: - #156 This manually adds the `accordion-section--expanded` to relevant sections using JavaScript that runs before the Accordions initialise.
92 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This is to maintain the state of the page when users browse back from the results
Also contains a fix for the IDs on subject filter checkboxes.
Changes proposed in this pull request
Adds an
optionsobject to the accordion component that allows consumers to pass in aforceSectionExpandedFnas an escape hatch. The reason for this approach is in order to hoist the checkbox-specific logic outside of the component itself.