Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter Sentry gtag errors #4968

Merged
merged 2 commits into from
Jun 25, 2024
Merged

Filter Sentry gtag errors #4968

merged 2 commits into from
Jun 25, 2024

Conversation

steventux
Copy link
Contributor

Context

We have gtag related fetch errors in production which we can't really action.

Changes proposed in this pull request

Filter out failed JS fetch errors from Sentry.

Guidance to review

See DFE-Digital/apply-for-qualified-teacher-status@1dd0190 for working implementation of how we access Sentry error descriptions to filter errors.

@steventux steventux force-pushed the filter-sentry-gtag-js-errors branch from d5b2027 to 94d72d4 Compare June 19, 2024 10:43
@steventux steventux requested a review from a team June 19, 2024 10:44
@steventux steventux changed the title Filter sentry gtag js errors Filter Sentry gtag errors Jun 19, 2024
Copy link

Review app deployed to https://cpd-ecf-review-4968-web.test.teacherservices.cloud

These are unactionable and create noise in our alerts channel.
See DFE-Digital/apply-for-qualified-teacher-status@1dd0190 for background on how we use filtering in other services.
@steventux steventux force-pushed the filter-sentry-gtag-js-errors branch from 492d00d to 6c3ec1a Compare June 19, 2024 14:59
@steventux steventux force-pushed the filter-sentry-gtag-js-errors branch from 6c3ec1a to 8560424 Compare June 19, 2024 15:01
Copy link
Contributor

@tonyheadford tonyheadford left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Be nice to quieten down these, thanks!

@steventux steventux added this pull request to the merge queue Jun 25, 2024
Merged via the queue into main with commit 73ee82c Jun 25, 2024
30 checks passed
@steventux steventux deleted the filter-sentry-gtag-js-errors branch June 25, 2024 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants