Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Upgrade govuk frontend and enable link styles #5036

Merged
merged 2 commits into from
Jun 29, 2021
Merged

Upgrade govuk frontend and enable link styles #5036

merged 2 commits into from
Jun 29, 2021

Conversation

frankieroberto
Copy link
Contributor

The new link styles are currently opt-in. The main differences are:

Links now have underlines that are consistently thinner and a bit further away from the link text.

Links also have a clearer hover state, where the underline gets thicker to make the link stand out to users.

Version 3.13.0 of govuk-frontend disables ink skipping of underlines in hover state to avoid large gaps appearing in the underline on hover in Safari and Firefox.

@frankieroberto frankieroberto added Candidate Candidate facing issue CSS ProVendor Provider or Vendor facing issue Provider UI labels Jun 25, 2021
@duncanjbrown duncanjbrown temporarily deployed to apply-for-te-upgrade-go-en0asm June 25, 2021 09:16 Inactive
paulrobertlloyd
paulrobertlloyd approved these changes Jun 25, 2021
View reviewed changes
Copy link
Contributor

@paulrobertlloyd paulrobertlloyd left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I think we’ll need a second PR to roll these styles out to our own components – I know that primary nav could do with a review based on these changes.

@paulrobertlloyd
Copy link
Contributor

Mr @adamsilver says ‘Yes’!

@paulrobertlloyd paulrobertlloyd merged commit 13304bf into master Jun 29, 2021
@paulrobertlloyd paulrobertlloyd deleted the upgrade-govuk-frontend-and-enable-link-styles branch June 29, 2021 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paulrobertlloyd paulrobertlloyd paulrobertlloyd approved these changes

@adamsilver adamsilver Awaiting requested review from adamsilver

Assignees
No one assigned
Labels
Candidate Candidate facing issue CSS ProVendor Provider or Vendor facing issue Provider UI
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@frankieroberto @paulrobertlloyd @duncanjbrown