Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: πŸ€– Add Newsletter section for DEV Rhylme substack org #158

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

yashksaini-coder
Copy link
Member

βœ… Fixes: #136

Description

This pull request includes several changes to the Footer component in src/components/Footer/index.tsx. The most significant changes include the addition of a new newsletter subscription section and various formatting adjustments to improve code readability.

Additions:

  • Added a new Substack newsletter embed section to the footer to allow users to subscribe to the newsletter.

Formatting Adjustments:

  • Adjusted the closing tags of img, PrivacyPolicyPopup, and svg elements to be on the same line as the last attribute. [1] [2] [3]
  • Combined two div elements into one for better code structure.

Minor Changes:

  • Added a blank line between state declarations and the useEffect hook for better code readability.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Test Configuration:

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

βœ… Closes: DEVRhylme-Foundation#136

Signed-off-by: yashksaini-coder <ys3853428@gmail.com>
@yashksaini-coder
Copy link
Member Author

@Durgesh4993 Kindly check this PR

@devsayanR
Copy link
Member

@Durgesh4993 Kindly check this PR

Why the newsletter image isn't showing

@yashksaini-coder
Copy link
Member Author

@Durgesh4993 Kindly check this PR

Why the newsletter image isn't showing

I also searched for that error, I tried using in different ways still the same result. Might be something to do on the other side maybe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Ready
Development

Successfully merging this pull request may close these issues.

Add Newsletter on the Footer
2 participants