Fix for issue with private key no longer working as a buffer #347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
So with the bump of @octokit/auth-app from v6.* -> v7.* it bumped its own dependency of universal-github-app-jwt from v1.* -> v2.* The universal-github-app-jwt v2 has introduced some work that replaces newlines within private keys - https://github.com/gr2m/universal-github-app-jwt/blob/d52064d3395a02363b6f80afeeb5d91e0a5f2040/index.js#L17 This work looks like it came in in v2.1.1 - gr2m/universal-github-app-jwt#96 Essentially what this means is with the latest version the privateKey must be a string rather than a buffer. This code fixes this issue
flurdy
approved these changes
Jan 22, 2025
feedmypixel
added a commit
that referenced
this pull request
Jan 24, 2025
This refactor means that the tests and production code are using the same work. The only difference being the stubs pass a baseUrl to point to cdp-portal-stubs, in Journey tests. This work will now the privateKey error we had in #347
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So with the bump of @octokit/auth-app from
v6.*->v7.*it bumped its own dependency of universal-github-app-jwt fromv1.*->v2.*The
universal-github-app-jwtv2has introduced some work that replaces newlines within private keys - https://github.com/gr2m/universal-github-app-jwt/blob/d52064d3395a02363b6f80afeeb5d91e0a5f2040/index.js#L17This work looks like it came in in
v2.1.1- gr2m/universal-github-app-jwt#96Essentially what this means is with the latest version the privateKey must be a string rather than a buffer.
This commit fixes this issue