Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

376121: Search functionality in dropdown list with Autocomplete #142

Merged
merged 11 commits into from
Jun 5, 2024

Conversation

jeevankuduvaravindran
Copy link
Contributor

@jeevankuduvaravindran jeevankuduvaravindran commented Jun 4, 2024

What this PR does / why we need it:

Search functionality in dropdown list with Autocomplete
Updated unit tests
AB#376121

Special notes for your reviewer

MUI Autocomplete has got some known issues where the output of the component is raw option whereas the expected value is just the option value. Tracked in the below issue in github repo.
mui/material-ui#23708

Testing

Any relevant testing information and pipeline runs.

Checklist (please delete before completing or setting auto-complete)

  • Story Work items associated (not Tasks)
  • Successful testing run(s) link provided
  • Title pattern should be {work item number}: {title}
  • Description covers all the changes in the PR
  • This PR contains documentation
  • This PR contains tests
  • Version number in package.json has been updated

Dependency check (tick or delete)

Have you updated any related templates, repositories or dependencies for new changes? We must ensure any dependencies like Software Templates are updated to include the latest changes to be scaffolded for all services where applicable.

How does this PR make you feel:

gif

jeevankuduvaravindran and others added 4 commits May 30, 2024 13:47
Signed-off-by: Jeevan Kuduva Ravindran <119388966+jeevankuduvaravindran@users.noreply.github.com>
Copy link

sonarqubecloud bot commented Jun 5, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
89.8% Coverage on New Code (required ≥ 90%)
41.8% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@jeevankuduvaravindran jeevankuduvaravindran merged commit 2b8a48f into main Jun 5, 2024
4 of 5 checks passed
@jamescoxheadcapgemini jamescoxheadcapgemini deleted the jk/multiselect-search branch June 5, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants