-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
376121: Search functionality in dropdown list with Autocomplete #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Signed-off-by: Jeevan Kuduva Ravindran <119388966+jeevankuduvaravindran@users.noreply.github.com>
jamescoxheadcapgemini
previously approved these changes
Jun 4, 2024
danny-may
approved these changes
Jun 5, 2024
|
jamescoxheadcapgemini
approved these changes
Jun 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Search functionality in dropdown list with Autocomplete
Updated unit tests
AB#376121
Special notes for your reviewer
MUI Autocomplete has got some known issues where the output of the component is raw option whereas the expected value is just the option value. Tracked in the below issue in github repo.
mui/material-ui#23708
Testing
Any relevant testing information and pipeline runs.
Checklist (please delete before completing or setting auto-complete)
{work item number}: {title}
Dependency check (tick or delete)
Have you updated any related templates, repositories or dependencies for new changes? We must ensure any dependencies like Software Templates are updated to include the latest changes to be scaffolded for all services where applicable.
How does this PR make you feel: