Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests: some simulated events are broken #286

Closed
magoni opened this issue Sep 8, 2015 · 1 comment
Closed

Tests: some simulated events are broken #286

magoni opened this issue Sep 8, 2015 · 1 comment

Comments

@magoni
Copy link
Contributor

magoni commented Sep 8, 2015

It seems that PhantomJS and jQuery Simulate are not working together for some of our unit tests that simulate navigation, and thus some tests are failing.

Upgrading to PhantomJS 2 locally solved the problem, but this version is not ready to be built reliably on Linux.

Also related to ariya/phantomjs#10375. Will look into another solution for simulating pointer events. For now, temporarily removing the offending unit tests to be re-integrated for 4.1.

@magoni magoni self-assigned this Sep 8, 2015
@magoni magoni added this to the RELEASE-4.1 milestone Sep 8, 2015
magoni added a commit that referenced this issue Sep 8, 2015
…ate bug

PhantomJS is not playing nice with jQuery Simulate, so tests that simulate pointer events are not working properly right now. This will be fixed once PhantomJS 2 is stable. For now, temporarily removing these tests to push 4.0 out the door.

Refs #286
@magoni
Copy link
Contributor Author

magoni commented Sep 17, 2015

Turns out the test also doesn't work when run in QUnit in the browser, and we're not using jQuery simulate (for the double click, which is not working) but rather just triggering a jQuery event. The test code does work when run in a standalone Diva instance. Still debugging.

@magoni magoni changed the title Tests: PhantomJS/jQuery Simulate incompatibilities Tests: some simulated events are broken Sep 17, 2015
magoni added a commit that referenced this issue Jan 29, 2016
The problem with jQuery event handlers not being fired when triggering them using a manually instantiated $.Event object has been resolved with phantomjs 2, which we can now use in our build/testing system because a static Linux build for 2.1 finally became available through npm yesterday.

npm automatically changed some formatting, but the only actual change is in the phantomjs package.

Fixes #286
@magoni magoni closed this as completed Jan 29, 2016
magoni added a commit that referenced this issue Jan 29, 2016
Phantomjs changed the package name once the 2.1 official package was released.

Refs #286
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant