Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves the socket input in FEVER by introducing a buffer for the input channel after parsing EVE from the socket.
The buffer is implemented using a variable-size buffered Go channel (
--in-buffer
) which will ensure that FEVER can keep up reading from the socket even if the processing pipeline or the forwarding receiver temporarily blocks.If the buffer fills completely, we will optionally (
--in-buffer-drop
) rather drop parsed events from the buffer than cause writes to the input socket to block. This is all done to prevent Suricata from ever having to block its internal pipelines, leading to packet drops with an even wider impact.We also send new metrics if the socket input is selected:
input_buffer_length
andinput_buffer_dropped
.