Dead code removal #101
Merged
Dead code removal #101
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cafkafk
added a commit
to eza-community/eza
that referenced
this pull request
Jan 23, 2025
Apparently, upstream rust decided to change the behavior of dead/unused code detection in a way that causes a lot of false positives. For some (yet known) reason, this only hit on the windows build, but I've confirmed that these are indeed false positives, and removing this "dead code" breaks the build. Frustratingly, we only hit this to fix *another issue*[1] with upstream rust... And this litters our code with directives where we "allow unused" that isn't unused. I coindicentally also saw this at dayjob today[2], and yes, this is real, so we'll just have to do it. Refs: [1] rust-lang/rust@e69f14b Refs: [2] DBCDK/faythe#101 Refs: rust-lang/rust#88900 Refs: #1342 Signed-off-by: Christina Sørensen <ces@fem.gg>
cafkafk
added a commit
to eza-community/eza
that referenced
this pull request
Jan 23, 2025
Apparently, upstream rust decided to change the behavior of dead/unused code detection in a way that causes a lot of false positives. For some (yet known) reason, this only hit on the windows build, but I've confirmed that these are indeed false positives, and removing this "dead code" breaks the build. Frustratingly, we only hit this to fix *another issue*[1] with upstream rust... And this litters our code with directives where we "allow unused" that isn't unused. I coindicentally also saw this at dayjob today[2], and yes, this is real, so we'll just have to do it. Refs: [1] rust-lang/rust@e69f14b Refs: [2] DBCDK/faythe#101 Refs: rust-lang/rust#88900 Refs: #1342 Signed-off-by: Christina Sørensen <ces@fem.gg>
cafkafk
added a commit
to eza-community/eza
that referenced
this pull request
Jan 23, 2025
Apparently, upstream rust decided to change the behavior of dead/unused code detection in a way that causes a lot of false positives. For some (yet known) reason, this only hit on the windows build, but I've confirmed that these are indeed false positives, and removing this "dead code" breaks the build. Frustratingly, we only hit this to fix *another issue*[1] with upstream rust... And this litters our code with directives where we "allow unused" that isn't unused. I coindicentally also saw this at dayjob today[2], and yes, this is real, so we'll just have to do it. Refs: [1] rust-lang/rust@e69f14b Refs: [2] DBCDK/faythe#101 Refs: rust-lang/rust#88900 Refs: #1342 Signed-off-by: Christina Sørensen <ces@fem.gg>
Leaves in one:
```
warning: field `0` is never read
--> src/issuer.rs:246:28
|
246 | NoIpsForResolversFound(&'l String),
| ---------------------- ^^^^^^^^^^
| |
| field in this variant
|
= note: `#[warn(dead_code)]` on by default
help: consider changing the field to be of unit type to suppress this warning while preserving the field numbering, or remove the field
|
246 | NoIpsForResolversFound(()),
|
```
That one should probably be dealt with after the next nixpkgs bump,
because it'll start affecting every field that is only read via derived
Debug traits. That seems to warrant some discussion.
983dcd3 to
a0df172
Compare
|
Not draft. Not dealing with the final dead_code warning due to the upcoming clippy MR + nixpkgs update which will bring in a lot more of them. |
|
0z13
approved these changes
Jan 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.