Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update badges on README #513

Merged
merged 1 commit into from
Feb 10, 2025
Merged

Update badges on README #513

merged 1 commit into from
Feb 10, 2025

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Feb 8, 2025

Updates the badges to remove deprecated one

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Important

Update README.md to remove deprecated badge and update LinkedIn link.

  • README.md:
    • Removed deprecated AI Code Agent badge.
    • Updated LinkedIn link to dagworks-inc.

This description was created by Ellipsis for 534d466. It will automatically update as commits are pushed.

Updates the badges to remove deprecated one
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 534d466 in 1 minute and 19 seconds

More details
  • Looked at 14 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 4 drafted comments based on config settings.
1. README.md:9
  • Draft comment:
    Deprecated 'AI-Code Agent' badge removed. Confirm that its removal does not affect any integrations.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
2. README.md:10
  • Draft comment:
    Updated LinkedIn URL from 'dagster' to 'dagworks-inc'. Verify that this URL is correct for the intended LinkedIn showcase.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
3. README.md:10
  • Draft comment:
    Removal of the deprecated AI-Code Agent badge looks intentional. Please ensure that any related references in the documentation are updated accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 0% <= threshold 50%
    None
4. README.md:11
  • Draft comment:
    For security best practices, consider adding rel="noopener noreferrer" to anchor tags with target="_blank" to prevent potential tab-napping vulnerabilities.
  • Reason this comment was not posted:
    Decided after close inspection that this draft comment was likely wrong and/or not actionable: usefulness confidence = 20% vs. threshold = 50%
    While the security suggestion is technically correct and a good practice, this is a README.md file with simple social media/badge links. The risk of tab-napping from these types of links is extremely low. The comment feels overly cautious for this context and doesn't meaningfully improve security given these are just social media badges.
    I could be underestimating the security risk - any external link could potentially be dangerous. Also, implementing the suggestion is very low effort.
    While the fix is easy, we should maintain a reasonable balance between security and practicality. For a README with simple social media links, this feels like security theater rather than meaningful protection.
    The comment should be removed as it suggests an overly cautious security measure for a very low-risk context of social media badge links in a README file.

Workflow ID: wflow_Jhe9CmIq1kVxQBwH


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Feb 8, 2025

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/513

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/513/

@skrawcz skrawcz enabled auto-merge (rebase) February 8, 2025 18:19
@skrawcz skrawcz disabled auto-merge February 10, 2025 22:32
@skrawcz skrawcz merged commit e18424d into main Feb 10, 2025
11 checks passed
@skrawcz skrawcz deleted the skrawcz-patch-2 branch February 10, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant