Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor UI fixes #480

Merged
merged 3 commits into from
Dec 16, 2024
Merged

Minor UI fixes #480

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
db19afd
Fixes issue with Burr demo
elijahbenizzy Dec 16, 2024
d073e7f
Fixes embedded sub-table-row
elijahbenizzy Dec 16, 2024
2bbcd45
Fixes table row that didn't expand the whole length
elijahbenizzy Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions telemetry/ui/src/components/routes/app/AppView.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,8 +392,9 @@ export const AppView = (props: {
}

if (error) return <div>Error loading steps</div>;
if (data === undefined || backendSpec === undefined || annotationsData === undefined)
if (data === undefined || backendSpec === undefined) {
return <Loading />;
}
const displayAnnotations = props.allowAnnotations && backendSpec.supports_annotations;
// TODO -- re-enable this if I want...
// const previousActions =
Expand Down Expand Up @@ -513,7 +514,7 @@ export const AppView = (props: {
setTopToBottomChronological={setTopToBottomChronological}
toggleInspectViewOpen={() => setInspectViewOpen(!inspectViewOpen)}
displayAnnotations={displayAnnotations}
annotations={annotationsData}
annotations={annotationsData || []}
/>
</div>
{!fullScreen && props.orientation === 'stacked_horizontal' && (
Expand Down
4 changes: 2 additions & 2 deletions telemetry/ui/src/components/routes/app/StepList.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -652,7 +652,7 @@ const StepSubTableRow = (props: {
setCurrentSelectedIndex={setCurrentSelectedIndex}
>
<TableCell
className={` ${lightText} w-10 min-w-10 ${props.displaySpanID ? '' : 'text-opacity-0'} flex flex-row`}
className={` ${lightText} w-10 min-w-10 ${props.displaySpanID ? '' : 'text-opacity-0'}`}
>
<RecursionDepthPadding depth={props.depth}>
<span>{spanIDUniqueToAction}</span>
Expand Down Expand Up @@ -735,7 +735,7 @@ const StepSubTableRow = (props: {
)}
</TableCell>
<TableCell className="" />
{props.displayAnnotations && <TableCell className="" />}
<TableCell className="" />
</>
) : (
<TableCell colSpan={5}></TableCell>
Expand Down
Loading