Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds docs for update() function to Reducer #447

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

elijahbenizzy
Copy link
Contributor

@elijahbenizzy elijahbenizzy commented Dec 2, 2024

Requested by @gamarin2!


Important

Add docstring to update() method in Reducer class in burr/core/action.py to explain state update process and parameters.

  • Docs:
    • Add docstring to update() method in Reducer class in burr/core/action.py.
    • Explains state update process, immutability, and two-step action context.
    • Describes parameters result and state, and return value State.

This description was created by Ellipsis for d7a5822. It will automatically update as commits are pushed.

@elijahbenizzy elijahbenizzy marked this pull request as ready for review December 2, 2024 15:49
Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to d7a5822 in 10 seconds

More details
  • Looked at 24 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. burr/core/action.py:129
  • Draft comment:
    Consider clarifying that the state is immutable and a new state object must be returned, rather than modifying the existing state in place.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The docstring for the update method in the Reducer class is clear and informative. However, it could benefit from a minor clarification regarding the immutability of the state.

Workflow ID: wflow_jiyHpfZg1KXV7DdU


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

Copy link

github-actions bot commented Dec 2, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/447

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/447/

@elijahbenizzy elijahbenizzy merged commit 1cde57e into main Dec 2, 2024
11 checks passed
@elijahbenizzy elijahbenizzy deleted the add-reducer-updates branch December 2, 2024 15:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant