Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates parallel notebook for google collab #432

Merged
merged 1 commit into from
Nov 21, 2024

Conversation

skrawcz
Copy link
Contributor

@skrawcz skrawcz commented Nov 21, 2024

Updating example for google collab

Changes

How I tested this

Notes

Checklist

  • PR has an informative and human-readable title (this will be pulled into the release notes)
  • Changes are limited to a single goal (no scope creep)
  • Code passed the pre-commit check & code is left cleaner/nicer than when first encountered.
  • Any change in functionality is tested
  • New functions are documented (with a description, list of inputs, and expected output)
  • Placeholder code is flagged / future TODOs are captured in comments
  • Project documentation has been updated if adding/changing functionality.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 72101b0 in 9 seconds

More details
  • Looked at 15 lines of code in 1 files
  • Skipped 1 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. docs/concepts/tracking.rst:111
  • Draft comment:
    Consider adding a brief explanation that the following code is specific to Google Colab and is necessary to expose the port for the Burr UI to be accessible in the Colab environment.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The added code for Google Colab is useful but lacks context for users unfamiliar with Colab specifics.

Workflow ID: wflow_qOiboGrQapdAsVrG


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@skrawcz skrawcz merged commit 326fa01 into main Nov 21, 2024
11 checks passed
@skrawcz skrawcz deleted the update_parallelism_example branch November 21, 2024 08:40
Copy link

github-actions bot commented Nov 21, 2024

A preview of is uploaded and can be seen here:

https://burr.dagworks.io/pull/432

Changes may take a few minutes to propagate. Since this is a preview of production, content with draft: true will not be rendered. The source is here: https://github.com/DAGWorks-Inc/burr/tree/gh-pages/pull/432/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant