Added cw-orch + Implemented Deploy trait #54
Conversation
artifacts/polytone_listener.wasm
Outdated
There was a problem hiding this comment.
Do we have to commit the wasm binaries?
There was a problem hiding this comment.
Could we have a cargo command or something that builds them and then runs cw-orch?
There was a problem hiding this comment.
The idea is for projects that integrate with polytone to be able to import the cw-orch structure along with the artifacts and the deployments (code_ids here).
Compiling the binaries from an imported project yourself, doesn't really make sense and adds a level of complexity for contract developers that can be avoided by having the artifacts in the repo.
What do you think ?
There was a problem hiding this comment.
Binaries can be compiled and added to tagged releases. A simple script can fetch them.
Alternatively, people can compile them.
Just worry about them:
a.) getting out of date
b.) having to check them every PR
c.) taking up space in git history (not too big of a deal, but minor annoyance IMO)
There was a problem hiding this comment.
We have a github action that builds and commits them whenever something is committed to main.
We could move that over and keep the artifacts dir in the .gitignore. Let the CI handle building them.
There was a problem hiding this comment.
We could move that over and keep the artifacts dir in the .gitignore. Let the CI handle building them.
Sounds sensible to me!
|
@JakeHartnell Could you use your credentials in the commit step of the artifacts build? I tested the action here. |
packages/interface/Cargo.toml
Outdated
| @@ -0,0 +1,19 @@ | |||
| [package] | |||
| name = "cw-orch-polytone" | |||
There was a problem hiding this comment.
Nit about the folder name... interface implies to me that it's an interface (i.e. the messages, responses, and general structs used by the polytone contracts. However, cw-orch-polytone is not that.
IMO, let's call the folder cw-orch-polytone or deployer or something like that.
A question for you for other libraries you might add something similar to (DAO DAO would be sick)... is this a package? Or perhaps it belongs in another folder.
Keeping it in packages is fine for now, but please rename to cw-orch-polytone or deployer (slight preference for the former). Sorry in advance for this annoying nit pick. 😂
There was a problem hiding this comment.
Will change the name, but that's a package ! That's something you can import from other projects to use the interface and associated state/artifacts.
state.json
Outdated
There was a problem hiding this comment.
Is state the standard filename for cw-orch? IMO, something less generic would be nicer for projects integrating cw-orch. Maybe something like cw-orch-state.json? Says exactly what it is... so I don't have to wonder... what is this random state.json file.
There was a problem hiding this comment.
Also, maybe double check if new chains have been added here?
.gitignore
Outdated
| hash.txt | ||
| contracts.txt | ||
| artifacts/ |
There was a problem hiding this comment.
Let's re-add artifacts to the .gitignore here. As discussed with @CyberHoward.
|
FYI, seems like CI keeps failing... maybe unrelated, but would like to see CI pass before merging: https://github.com/DA0-DA0/polytone/actions/runs/6507738068 This is getting close! |
This CI job is on main (https://github.com/DA0-DA0/polytone/blob/main/.github/workflows/audit_dependencies.yml) so not something we touched. Should be fixed in a different PR. |
cw-orch-state.json
Outdated
There was a problem hiding this comment.
What do you think about including the addresses of a deployment just like I did here, and adding those you already have done on other chains in the cw-orch-state.json file as well ?
This would help projects identify the deployed polytone addresses to not have to worry about them, just using the polytone package to integrated with ?
|
Please rebase or merge latest main, CI has been fixed: #56 |
Rebased now |
Updated all polytone deployments. Migaloo missing
This is now done |
This PR aims at adding cw-orch into the repository.
It is done in 3 steps :
maincontractDeploytrait to easily deploy and reuse polytone on the chain where it is deployedExecuteMsgandQueryMsgdefinitions of voice/proxy/note