Fixes all the compiler warnings #82
Conversation
| let mut unwrapped_items: Vec<&syn::Item> = vec![]; | ||
| for item in ast { | ||
| match item { |
There was a problem hiding this comment.
This match was weird.
Is it correct that in case it matches an Item::Mod(...) but without a content that it does nothing?
Current implementation reflects original code, not sure if it reflects the intention though.
| @@ -463,20 +459,16 @@ pub fn build_method_delegate_if_required( | |||
| method_name: &String, | |||
| parameter_name: &String, | |||
| ) -> Option<String> { | |||
| let emit_from_struct = false; | |||
There was a problem hiding this comment.
This is weird. emit_from_struct is always false (unless I'm wrong and missing something big) which could be a choice for readability. But it's not a const, and has implications in the next line.
| match &me.type_kind { | ||
| TypeKind::Function(parameters, return_type) => { | ||
| if emit_from_struct && !options.csharp_use_function_pointer { |
There was a problem hiding this comment.
So... if emit_from_struct is always false, can this actually ever be the case? I removed the branch; this was likely a copy/paste leftover, but might be worth checking if it isn't some kind of bug.
|
Ah, I see, the point you raised seems to be an actual mistake. |
a0e36cc to
54618c5
Compare
|
I also rebased this and ran cargo fmt. I will be away from any sort of keyboards until the end of July (vacation time!). If you find anything wrong, I can check the PRs as soon as I'm back. |
54618c5 to
afbab0f
Compare
|
Rebased and fmt'ed again. |
|
This PR is stale because it has been open 180 days with no activity. Remove stale label or comment or this will be closed in 30 days. |
This fixes all compiler warnings and all clippy warnings. I highlight some weird cases in the diff below, for you to double-check.