-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Many Rivers #115
Open
CyprienBosserelle
wants to merge
25
commits into
development
Choose a base branch
from
ManyRivers
base: development
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Many Rivers #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
using the same test: |
Using the same setup as above but rerunning each scenarios. (Waitaki domain, single level (256m res). 3600 s run )
Results between old and new code are exactly identical but the new code is 7 times faster with 675 rivers. Tip SUCCESS |
Two Birds, one PRMomentum conserving rain inputAlso added a momentum preserving correction for u and v when adding rain input. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve efficiency if may rivers are involved
I'm changing the structure of the model workflow to be efficient if a lot of rivers are in the model.
Currently kernels are launched in serial for each river. This is very inefficient when you have many rivers.
In an example using a crud model of the lower Waitaki River.
This doesn't look too bad but things gets worse in other setting (may need a better example to make the point about the point of this)