Implement (dump) NATS reconnection attempts on startup #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
$ make ci
go mod verify
all modules verified
golangci-lint run
go build ./...
go build
go test ./...
? github.com/CyCoreSystems/ari-proxy/v5 [no test files]
ok github.com/CyCoreSystems/ari-proxy/v5/client 0.046s
ok github.com/CyCoreSystems/ari-proxy/v5/client/bus 0.012s
ok github.com/CyCoreSystems/ari-proxy/v5/client/cluster 0.056s
? github.com/CyCoreSystems/ari-proxy/v5/internal/integration [no test files]
? github.com/CyCoreSystems/ari-proxy/v5/proxy [no test files]
ok github.com/CyCoreSystems/ari-proxy/v5/server 0.058s
ok github.com/CyCoreSystems/ari-proxy/v5/server/dialog 0.005s
ok github.com/CyCoreSystems/ari-proxy/v5/session 0.002s |
Ulexus
requested changes
Nov 11, 2020
a85ee9d to
171af32
Compare
|
Fixed and force-pushed, please continue review / acceptance consideration. |
Ulexus
approved these changes
Nov 11, 2020
|
Thanks @blaggacao ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #37
This is a non-configurable ("dump") implementation. I dind't think it was worth it to expose a configuration flag for all edge cases here. If the start up fails due to non connectivity after a total of 25 seconds, then a k8s restart loop probably is within the budget.
This change is