fix incorrect popup ordering in bi layers

Cvolton · Oct 17, 2024 · 0ece5c7 · 0ece5c7
1 parent 12dc199
commit 0ece5c7
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/mod.json b/mod.json
@@ -1,5 +1,5 @@
 {
-    "geode": "3.7.1",
+    "geode": "3.8.1",
     "version": "v4.2.10",
     "gd": {
         "win": "2.206",

diff --git a/src/layers/_bases/BIBaseLayer.cpp b/src/layers/_bases/BIBaseLayer.cpp
@@ -108,12 +108,16 @@ void BIBaseLayer::onEnterTransitionDidFinish() {
     CCLayer::onEnterTransitionDidFinish();
 
     //workaround for no esc catching bug
+    std::vector<Ref<FLAlertLayer>> alerts;
+
     size_t i = 0;
-    while(Ref<FLAlertLayer> alert = getChildOfType<FLAlertLayer>(this, i++)) {
-        alert->retain();
+    while(auto alert = getChildOfType<FLAlertLayer>(this, i++)) {
+        alerts.push_back(alert);
+    }
+
+    for(auto alert : alerts) {
         alert->removeFromParentAndCleanup(false);
         alert->m_noElasticity = true;
         alert->show();
-        alert->release();
     }
 }