Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better teardown logging #558

Merged
merged 7 commits into from
Jun 9, 2023
Merged

Better teardown logging #558

merged 7 commits into from
Jun 9, 2023

Conversation

tannermpeterson
Copy link
Collaborator

No description provided.

@tannermpeterson tannermpeterson force-pushed the better-teardown-logging branch from 9106e8a to 65e4255 Compare June 6, 2023 18:30
@tannermpeterson tannermpeterson marked this pull request as ready for review June 9, 2023 01:11
@codecov
Copy link

codecov bot commented Jun 9, 2023

Codecov Report

Patch coverage: 100.00% and no project coverage change.

Comparison is base (3ef583e) 100.00% compared to head (d75b3c3) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main      #558   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           29        29           
  Lines         6606      6630   +24     
  Branches       995      1000    +5     
=========================================
+ Hits          6606      6630   +24     
Flag Coverage Δ
unittests 100.00% <100.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...c/mantarray_desktop_app/simulators/mc_simulator.py 100.00% <ø> (ø)
src/mantarray_desktop_app/constants.py 100.00% <100.00%> (ø)
src/mantarray_desktop_app/sub_processes/mc_comm.py 100.00% <100.00%> (ø)

... and 1 file with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@tannermpeterson tannermpeterson merged commit 46d098a into main Jun 9, 2023
@tannermpeterson tannermpeterson deleted the better-teardown-logging branch June 9, 2023 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants