Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ModuleNotFoundError in conda environments #31

Merged
merged 1 commit into from
Oct 24, 2024

Conversation

dperozzi
Copy link
Contributor

This PR supersedes my previous solution (PR #29) to issues #12 and #23 that incorrectly relied on FORCE_CUDA. That approach masked the real issue, only working in my local setup due to additional dependencies that are not relevant in a clean environment.

Key changes:

  1. Removes unnecessary FORCE_CUDA workaround (as FORCE_CUDA is never used in this project's setup files)
  2. Adds optional global installation for compiled extensions in conda (Resolving ModuleNotFoundError )
  3. Maintains default local installation behavior

This solution properly addresses the module discovery issue while aligning with the project's existing setup procedure. Apologies for the confusion from my previous PR.

- Removed the (unnecessary) FORCE_CUDA flag from installation scripts.
- Added an option to install extensions globally within conda environments to ensure compiled extensions are found.
- Default behavior remains installing locally unless otherwise specified.
- Clarified installation instructions to prevent ModuleNotFoundError when using a conda environment
@CuiRuikai CuiRuikai merged commit bdb58b1 into CuiRuikai:main Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants