Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move google_tag configuration from optional to install #203

Closed
jcsparks opened this issue Sep 18, 2024 · 0 comments · Fixed by #204
Closed

Move google_tag configuration from optional to install #203

jcsparks opened this issue Sep 18, 2024 · 0 comments · Fixed by #204
Assignees
Labels
change Modification to code without a functional change

Comments

@jcsparks
Copy link
Member

There's 2 google_tag configuration files that are currently in config/optional :

  1. google_tag.container.GTM-M3DX2QP.65de22067902c7.57590325.yml
  2. google_tag.settings.yml

The first one should be moved to config/install. This is the configuration for the main CU GTM container and we want that to be the same across all of the sites.

The second one has configuration for tags that should be configured on the site. This one should remain in config/optional so that we don't overwrite any custom CTM container tags that are added after installation.

Currently all of the sites are still set to apply the GA code to all users despite the config saying that it should only be for the anonymous user because this config is in optional. Moving to install should resolve that issue.

@jcsparks jcsparks added the change Modification to code without a functional change label Sep 18, 2024
timurtripp added a commit that referenced this issue Sep 18, 2024
@timurtripp timurtripp self-assigned this Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
change Modification to code without a functional change
Projects
None yet
2 participants