Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds CU Boulder Styled Block custom module and updates block styles #1209

Merged
merged 8 commits into from
Aug 19, 2024
Merged

Adds CU Boulder Styled Block custom module and updates block styles #1209

merged 8 commits into from
Aug 19, 2024

Conversation

timurtripp
Copy link
Contributor

@timurtripp timurtripp commented Aug 13, 2024 •
edited
Loading

This update:

Sister PR in: ucb_campus_news, tiamat10-profile, tiamat10-project-template

@timurtripp timurtripp added change Modification to code without a functional change new New feature or request labels Aug 13, 2024
@timurtripp timurtripp requested a review from jnicholCU August 13, 2024 21:59
This was referenced Aug 13, 2024
Merged
Merged
Merged
@jnicholCU
CSS updates for hero unit block styles
c8a42ee 
Needed to change some css structure for the hero's block styles.
@jnicholCU
Update styled-block.html.twig
3c14e30 
Remove the first instance of `con_position`'s application.
Didn't need to be added at the container level.
@timurtripp timurtripp marked this pull request as ready for review August 13, 2024 22:56
jnicholCU and others added 3 commits August 13, 2024 17:14
@jnicholCU
Update block-styles.css
1a3b720 
Sibling selector is needed for the top icon positioning to work properly.
@jnicholCU
Hero Unit Design option fix
4ec6744 
The text align and color values needed to be moved so they apply at the correct level.
Currently they are being applied so that color and alignment affect the BS Title as well when they shouldn't. (This fix needed to be done in the previous version as well)
@timurtripp
Adds container class to Campus News block to fix padding issue
022e74c
@patrickbrown-io patrickbrown-io self-requested a review August 19, 2024 16:51
patrickbrown-io
patrickbrown-io approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@patrickbrown-io patrickbrown-io left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested 20 blocks with random individualized styles to each one and could not find any issues

jnicholCU
jnicholCU approved these changes Aug 19, 2024
View reviewed changes
Copy link
Contributor

@jnicholCU jnicholCU left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as Pat. I believe this is ready to merge.

@jnicholCU jnicholCU merged commit 832faec into main Aug 19, 2024
3 checks passed
@jnicholCU jnicholCU deleted the block-styles-refactor branch August 19, 2024 16:56
github-actions bot pushed a commit that referenced this pull request Aug 19, 2024
@jnicholCU @web-flow
Merge pull request #1209 from CuBoulder/block-styles-refactor
2c818ba 
Adds CU Boulder Styled Block custom module and updates block styles
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patrickbrown-io patrickbrown-io patrickbrown-io approved these changes

@jnicholCU jnicholCU jnicholCU approved these changes

Assignees
No one assigned
Labels
change Modification to code without a functional change new New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@timurtripp @patrickbrown-io @jnicholCU