Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Social Media Secondary and Footer Menu update #1051

Merged
merged 24 commits into from
Jun 20, 2024
Merged

Social Media Secondary and Footer Menu update #1051

merged 24 commits into from
Jun 20, 2024

Conversation

jacob-korf
Copy link
Contributor

@jacob-korf jacob-korf commented Jun 10, 2024

Closes #800.
Sister PR in #1051 (comment).
Adds functionality for the social media menu to be placed in the secondary menu and the footer menu areas. This will also delete the social media menu region.

@jcsparks jcsparks marked this pull request as draft June 11, 2024 20:39
@jcsparks
Copy link
Member

Secondary Menu issues:

  • Social Menu causes the default secondary menu to stack vertically instead of horizontally when inline:
Screenshot 2024-06-11 at 2 36 14 PM
  • Social menu causes the default secondary menu to be stacked vertically and float left when set to display above:
Screenshot 2024-06-11 at 2 37 53 PM
  • Social Media in the Footer Menu region by itself does not have enough vertical padding, leaving the grey bar too narrow compared to the normal Footer menu.
Screenshot 2024-06-11 at 2 36 35 PM
  • Footer Menu Region now appears below the Footer Region when the Social Menu is placed in the Footer region.
Screenshot 2024-06-11 at 2 37 25 PM

@jcsparks jcsparks marked this pull request as ready for review June 17, 2024 22:49
@jcsparks jcsparks self-requested a review June 20, 2024 14:40
@jcsparks jcsparks merged commit fb8b182 into main Jun 20, 2024
5 checks passed
@jcsparks jcsparks deleted the issue/800 branch June 20, 2024 15:01
github-actions bot pushed a commit that referenced this pull request Jun 20, 2024
Social Media Secondary and Footer Menu update
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Social Media Links Menu & Social Media Menu Region
2 participants