MHP 3099 -- Convert Celebrate Feed to GraphQL & Add Polling #1444
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # src/components/CelebrateItem/index.tsx # src/containers/CelebrateDetailScreen/__tests__/__snapshots__/CelebrateDetailScreen.tsx.snap # src/containers/CelebrateDetailScreen/index.tsx # src/containers/CelebrateFeed/__tests__/__snapshots__/CelebrateFeed.tsx.snap # src/containers/CelebrateFeed/index.tsx # testUtils/globalMocks.ts
reldredge71
commented
Jan 30, 2020
src/containers/CelebrateDetailScreen/__tests__/CelebrateDetailScreen.tsx
Outdated
Show resolved
Hide resolved
OzzieOrca
reviewed
Jan 31, 2020
src/containers/CelebrateDetailScreen/__tests__/CelebrateDetailScreen.tsx
Outdated
Show resolved
Hide resolved
src/components/CelebrateCommentBox/__tests__/CelebrateCommentBox.tsx
Outdated
Show resolved
Hide resolved
src/containers/CelebrateDetailScreen/__tests__/CelebrateDetailScreen.tsx
Outdated
Show resolved
Hide resolved
src/containers/CelebrateDetailScreen/__tests__/CelebrateDetailScreen.tsx
Outdated
Show resolved
Hide resolved
| return ( | ||
| <Fragment> | ||
| {isCommentCardVisible ? null : ( | ||
| //@ts-ignore |
There was a problem hiding this comment.
Same as above. The JSX renders fine and there are no lint errors, so I guess it's valid?
| {isMineNotReported ? <Flex value={1} /> : null} | ||
| {menuActions ? ( | ||
| <PopupMenu | ||
| // @ts-ignore |
| <CommentItem | ||
| //@ts-ignore |
# Conflicts: # src/containers/Groups/GroupUnreadFeed.tsx # src/containers/Groups/__tests__/GroupUnreadFeed.tsx # src/containers/Groups/__tests__/__snapshots__/GroupUnreadFeed.tsx.snap
OzzieOrca
previously approved these changes
Feb 3, 2020
| pollInterval: 30000, | ||
| notifyOnNetworkStatusChange: true, |
There was a problem hiding this comment.
This is already the global default https://github.com/CruGlobal/missionhub-react-native/blob/develop/src/apolloClient.ts#L84.
Suggested change
| notifyOnNetworkStatusChange: true, |
| story: 'story', | ||
| createdCommunity: 'V4::Organization', | ||
| joinedCommunity: 'V4::OrganizationalPermission', | ||
| story: 'V4::Story', |
There was a problem hiding this comment.
I made https://jira.cru.org/browse/MHP-3161 so hopefully we can just generate this type from the API in the future.
OzzieOrca
approved these changes
Feb 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Forgive me, I had no idea where to end on this!
I took the three screens that have the celebrate feed (GroupCelebrate, GroupUnread, and MemberCelebrate), ripped out the celebration feed stuff, and had all of the celebrate feed handling happen inside CelebrateFeed. I converted it to GraphQL so that we could add polling, refreshing every 30 seconds.
In doing so, there were MANY sub-components and screens branching off of CelebrateFeed that needed to be updated. Some needed to be converted from snake_case to camelCase due to the GraphQL change. Also several components were expecting organization to be a property of celebrateItem, which it is not in GraphQL, so I had to find work-arounds. I also decided to apply the new GraphQL generated types everywhere I could find. There were several components that would have broken if I left them untouched-- and then a few more that I probably could have left alone but felt good to convert.
I'm pretty sure I went overboard on this one. Let me know if there is anything that you want me to revert or improve. Thanks in advance!