Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wip pre deployment bug cleanup #58

Merged
merged 10 commits into from
Mar 8, 2023
Merged

Conversation

dylan-bourque
Copy link

This PR addresses several small issues including:

  • adding HTTP endpoints for health checks, Prometheus metrics, and Go pprof profiles
  • using PERSEUS_SERVER_ADDR instead of SERVER_ADDR for the env var that sets the Perseus server location
  • correct the response for ListModuleVersions to include the 'v' prefix on the semver strings
  • cleaning up README.md

@dylan-bourque dylan-bourque requested review from a team, wmorgan6796, ct16k and bndw February 28, 2023 20:39
internal/server/http.go Outdated Show resolved Hide resolved
@dylan-bourque dylan-bourque force-pushed the wip-pre-deployment-bug-cleanup branch from bb9902b to ff3e446 Compare March 6, 2023 22:45
added support for configuring the service's health check
timeout via the `HEALTHZ_TIMEOUT` env var, which can be
a duration string.  values < 0 are ignored and the default is 300ms.
@dylan-bourque dylan-bourque merged commit 6620a7d into main Mar 8, 2023
@dylan-bourque dylan-bourque deleted the wip-pre-deployment-bug-cleanup branch March 8, 2023 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants