Use Connect instead of gRPC #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
331b27e to
865106e
Compare
bufdev
reviewed
Apr 25, 2024
e1d3c1d to
93ad391
Compare
|
Ran |
dylan-bourque
commented
Apr 30, 2024
dylan-bourque
commented
Apr 30, 2024
bndw
approved these changes
Apr 30, 2024
There was a problem hiding this comment.
LGTM. Please update the README section on service architecture to reflect the change from grpc-gateway -> connect.
alee792
approved these changes
Apr 30, 2024
added 3 commits
May 3, 2024 13:03
add code generation using `protoc-gen-connect-go` replace gRPC server code w/ equivalnt Connect code replace grpc-gateway w/ Vanguard
replace gRPC client usage in the CLI with Connect client remove gRPC code generation updated README.md to reflect the switch to Connect
also updated bufbuild/httplb to v0.3.0
aac14e1 to
c43e27f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR swaps gRPC for Connect in both the server and CLI implementations. For compatibility with running instances of the Perseus service, we enable the gRPC wire protocol for the client. We have also replaced
grpc-gatewaywith Vanguard (connectrpc.com/vanguard) for JSON/REST support in the server's API.I have done compatibility testing using an old (gRPC) client hitting a new (Connect) server, a new client hitting an old server, and a new client hitting a new server.
The generated metrics are slightly different due to differences between the gRPC and Connect runtimes, but the things being monitored are the same.